On Wed, 2017-04-05 at 13:12 -0400, Rob Clark wrote:
> On Wed, Apr 5, 2017 at 12:14 PM, Philipp Zabel <p.za...@pengutronix.de> wrote:
> > +void
> > +etna_fence_server_sync(struct pipe_context *pctx,
> > + struct pipe_fence_handle *pfence)
> > +{
> > + struct etna_context *ctx = etna_context(pctx);
> > +
> > + /* FIXME: where should in_fence_fd be stored? */
> > + sync_accumulate("etnaviv", &ctx->in_fence_fd, pfence->fence_fd);
> > +}
> > +
>
>
> fwiw, sync_accumulate() gives you back a new fence that is signalled
> when both the original in_fence_fd and the new fence_fd are signalled.
> So you shouldn't need to track the old in_fence_fd.
Thanks, I've seen that sync_accumulate closes the old in_fence_fd.
This comment was about being unsure whether struct etna_context is the
right place for in_fence_fd. I'll just drop it.
regards
Philipp
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
