On 31/03/17 14:23, Emil Velikov wrote:
On 31 March 2017 at 11:42, Lionel Landwerlin
<lionel.g.landwer...@intel.com> wrote:
The GENXML_XML_FILES variable was missing the "srcdir" prefix, thus
the files won't be found on OOT builds.

Side note: If you want to spare yourself such fun experiences, CC me
on build related patches. Or poke me on IRC of course.

Thanks, will do.
Just sent a v2 that makes it a bit closer to genX_bits.h


Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>
---
  src/intel/Makefile.genxml.am | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am
index 05a12f8f77..d780ca8470 100644
--- a/src/intel/Makefile.genxml.am
+++ b/src/intel/Makefile.genxml.am
@@ -36,7 +36,7 @@ $(GENXML_GENERATED_PACK_FILES): genxml/gen_pack_header.py

  genxml/genX_xml.h: $(GENXML_XML_FILES) genxml/gen_zipped_file.py
         $(MKDIR_GEN)
-       $(AM_V_GEN) $(PYTHON2) $(srcdir)/genxml/gen_zipped_file.py 
$(GENXML_XML_FILES) > $@ || ($(RM) $@; false)
+       $(AM_V_GEN) $(PYTHON2) $(srcdir)/genxml/gen_zipped_file.py $(addprefix 
$(srcdir)/,$(GENXML_XML_FILES)) > $@ || ($(RM) $@; false)
Or even better:

        $(PYTHON_GEN) $(srcdir)/genxml/gen_zipped_file.py
$(GENXML_XML_FILES:%=$(srcdir)/%) > $@ || ($(RM) $@; false)

With the above
Reviewed-by: Emil Velikov <emil.veli...@collabora.com>

-Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to