On Mon 13 Mar 2017, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_device.c | 31 +++++++++++++++++--------------
> 1 file changed, 17 insertions(+), 14 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 5db0a6c..13c1c50 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -53,30 +53,34 @@ compiler_perf_log(void *data, const char *fmt, ...)
> va_end(args);
> }
>
> unsigned build_id_len = build_id_length(note);
> - if (build_id_len < 20) /* It should be a SHA-1 */
> - return false;
> + if (build_id_len < 20) {
> + return vk_errorf(VK_ERROR_INITIALIZATION_FAILED,
> + "build-id too short. It needs to be a SHA");
In above line, s/SHA/SHA-1/, to distinguish from SHA-2 and SHA-3
With that nit fixed,
Reviewed-by: Chad Versace <chadvers...@chromium.org>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
