Re: [Mesa-dev] [RFC 3/3] mesa: expose KHR_no_error for GL

[Timothy Arceri]

On 28/03/17 16:12, Ilia Mirkin wrote:

On Tue, Mar 28, 2017 at 1:10 AM, Timothy Arceri <t_arc...@yahoo.com.au> wrote:
On 28/03/17 15:39, Ilia Mirkin wrote:
Why can't we just have this on ES as-is? It should support context
flags just fine... that's how e.g. robustness is done there, no? (Note
that ES makes no requirement for EGL - an ES context can be created
with GLX as well, in case it matters.)
Well I guess we can enable it on ES also then. But the bigger question is
whether there is a requirement from an extension to enable it on GLX, see
patch 1.
Can't it just be passed in via context flags? These are passed in with
GLX_ARB_create_context(_profile), so should be fine, no?
The thing is that it seems there is normally a separate extensions to 
define the flag. For example [1] for

GLX_CONTEXT_ROBUST_ACCESS_BIT_ARB.

Also the GLX debug and forward compatible flags are defined as:

        GLX_CONTEXT_DEBUG_BIT_ARB               0x0001
        GLX_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB  0x0002

Where as the GL header files define:

/GL_CONTEXT_FLAG_FORWARD_COMPATIBLE_BIT 0x00000001/
//GL_CONTEXT_FLAG_DEBUG_BIT 0x00000002 /So hopefully someone can clear 
this up. /


[1] 
https://www.khronos.org/registry/OpenGL/extensions/ARB/GLX_ARB_create_context_robustness.txt

Anyone know if the Nvidia or AMD blobs enable this? I was told Feral games
might be using this but I'm becoming unsure about that. Either way it could
still be useful to enable it via a config option for some games.


On Tue, Mar 28, 2017 at 12:35 AM, Timothy Arceri <tarc...@itsqueeze.com>
wrote:
There ES is no support for now as this requires
EGL_KHR_create_context_no_error to be implemented.
---
   src/mesa/main/extensions_table.h | 1 +
   1 file changed, 1 insertion(+)

diff --git a/src/mesa/main/extensions_table.h
b/src/mesa/main/extensions_table.h
index ec71791..4439731 100644
--- a/src/mesa/main/extensions_table.h
+++ b/src/mesa/main/extensions_table.h
@@ -294,20 +294,21 @@ EXT(IBM_texture_mirrored_repeat             ,
dummy_true

   EXT(INGR_blend_func_separate                , EXT_blend_func_separate
, GLL,  x ,  x ,  x , 1999)

   EXT(INTEL_conservative_rasterization        ,
INTEL_conservative_rasterization       ,  x , GLC,  x ,  31, 2013)
   EXT(INTEL_performance_query                 , INTEL_performance_query
, GLL, GLC,  x , ES2, 2013)

   EXT(KHR_blend_equation_advanced             ,
KHR_blend_equation_advanced            , GLL, GLC,  x , ES2, 2014)
   EXT(KHR_blend_equation_advanced_coherent    ,
KHR_blend_equation_advanced_coherent   , GLL, GLC,  x , ES2, 2014)
   EXT(KHR_context_flush_control               , dummy_true
, GLL, GLC,  x , ES2, 2014)
   EXT(KHR_debug                               , dummy_true
, GLL, GLC,  11, ES2, 2012)
+EXT(KHR_no_error                            , dummy_true
, GLL, GLC,  x ,  x , 2015)
   EXT(KHR_robust_buffer_access_behavior       ,
ARB_robust_buffer_access_behavior      , GLL, GLC,  x , ES2, 2014)
   EXT(KHR_robustness                          , KHR_robustness
, GLL, GLC,  x , ES2, 2012)
   EXT(KHR_texture_compression_astc_hdr        ,
KHR_texture_compression_astc_hdr       , GLL, GLC,  x , ES2, 2012)
   EXT(KHR_texture_compression_astc_ldr        ,
KHR_texture_compression_astc_ldr       , GLL, GLC,  x , ES2, 2012)
   EXT(KHR_texture_compression_astc_sliced_3d  ,
KHR_texture_compression_astc_sliced_3d , GLL, GLC,  x , ES2, 2015)

   EXT(MESA_pack_invert                        , MESA_pack_invert
, GLL, GLC,  x ,  x , 2002)
   EXT(MESA_shader_integer_functions           ,
MESA_shader_integer_functions          , GLL, GLC,  x ,  30, 2016)
   EXT(MESA_texture_signed_rgba                , EXT_texture_snorm
, GLL, GLC,  x ,  x , 2009)
   EXT(MESA_window_pos                         , dummy_true
, GLL,  x ,  x ,  x , 2000)
--
2.9.3

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev