On 22 March 2017 at 10:57, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > On 22.03.2017 00:43, Grazvydas Ignotas wrote: >> >> Rather than using 3 different ways to wrap _mesa_sha1_*() to SHA1*() >> functions (a macro, prototype with implementation in .c and an inline >> function), make all 3 inline functions. >> >> Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> > > > Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> > > I noticed that a define is used for mesa_sha1. I wouldn't mind a change to > > typedef struct _SHA1_CTX *mesa_sha1; > Dull question - what does this bring us ?
> even though that would imply more changes throughout the code base. Might be > best to delay until some of the disk cache uses have settled, and it's > obviously not high priority. > Agreed. Thanks for having a look Nicolai and Grazvydas for sorting this out R-b and pushed to master. -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
