I was talking to Daniel today and I think we also need another some sort of GL or GBM api that gives you the modifiers supported for rendering/texturing. One option would be a gbm_get_modifiers_for_use() entrypoint that takes a usage and gives you a set of modifiers that's guaranteed to work for that usage. For scanout, it would return LINEAR, X, and Y on SKL+ and LINEAR and X on BDW-; it wouldn't return CCS because that only works on a limited number of planes. I say this now because we may want to do that with the same DRI version bump as the rest of it.
On Thu, Mar 9, 2017 at 5:48 PM, Ben Widawsky <b...@bwidawsk.net> wrote: > This is essential the creation and getter for GBM modifiers (via DRI > images). > > This was the second chunk of the Renderbuffer Decompression series (aka GBM > modifiers). Splitting this up to make merging easier. These patches are > simple > plumbing for getting modifiers through the various GBM functions as well as > exposing the new entry points. > > Ben Widawsky (3): > dri: Add an image creation with modifiers > gbm: Introduce modifiers into surface/bo creation > gbm: Export a get modifiers > > include/GL/internal/dri_interface.h | 27 ++++++++++- > src/egl/drivers/dri2/platform_drm.c | 19 ++++++-- > src/gallium/state_trackers/dri/dri2.c | 1 + > src/gbm/backends/dri/gbm_dri.c | 78 > +++++++++++++++++++++++++++++--- > src/gbm/gbm-symbols-check | 3 ++ > src/gbm/main/gbm.c | 48 +++++++++++++++++++- > src/gbm/main/gbm.h | 15 ++++++ > src/gbm/main/gbmint.h | 13 +++++- > src/mesa/drivers/dri/i965/intel_screen.c | 50 +++++++++++++++++++- > 9 files changed, 237 insertions(+), 17 deletions(-) > > -- > 2.12.0 > >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
