On Fri, Feb 24, 2017 at 03:30:50PM -0800, Matt Arsenault wrote: > > > On Feb 24, 2017, at 14:39, Marek Olšák <mar...@gmail.com> wrote: > > > > On Fri, Feb 24, 2017 at 7:20 PM, Matt Arsenault <arse...@gmail.com> wrote: > >> > >> On Feb 24, 2017, at 01:45, Marek Olšák <mar...@gmail.com> wrote: > >> > >> The main requirement is that if there is indirect indexing inside a > >> loop, we always want to unroll the whole loop to get rid of the > >> indexing, which can decrease scratch usage. > >> > >> Marek > >> > >> We boost the unroll thresholds when there is private memory indexed by the > >> induction variable. See AMDGPUTTIImpl::getUnrollingPreferences > > > > When Samuel Pitoiset was experimenting with the same code as this > > patch but for radeonsi, getUnrollingPreferences wasn't even getting > > called when unrolling. I guess he eventually gave up or didn't see any > > positive effect from it. > > > > Marek > > Then there’s a bug somewhere. It should be getting called
It's possible TargetTransformInfo isn't being setup correctly by the mesa pass pipeline. -Tom > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev