I have a tiny suggestion below and also one on patch 2.
Regardless, this series is :
Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>
On 18/02/17 23:59, Jason Ekstrand wrote:
---
src/intel/genxml/gen7.xml | 2 +-
src/intel/genxml/gen75.xml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml
index 57c3013..7368b5b 100644
--- a/src/intel/genxml/gen7.xml
+++ b/src/intel/genxml/gen7.xml
@@ -2314,7 +2314,7 @@
<field name="MI Command Opcode" start="23" end="28" type="uint"
default="32"/>
<field name="Use Global GTT" start="22" end="22" type="bool"/>
<field name="DWord Length" start="0" end="5" type="uint" default="2"/>
- <field name="Address" start="66" end="95" type="uint"/>
+ <field name="Address" start="66" end="95" type="address"/>
Would you mind updating gen6.xml too?
<field name="Core Mode Enable" start="64" end="64" type="uint"/>
<field name="Data DWord 0" start="96" end="127" type="uint"/>
<field name="Data DWord 1" start="128" end="159" type="uint"/>
diff --git a/src/intel/genxml/gen75.xml b/src/intel/genxml/gen75.xml
index 8260974..ed82236 100644
--- a/src/intel/genxml/gen75.xml
+++ b/src/intel/genxml/gen75.xml
@@ -2707,7 +2707,7 @@
<field name="MI Command Opcode" start="23" end="28" type="uint"
default="32"/>
<field name="Use Global GTT" start="22" end="22" type="bool"/>
<field name="DWord Length" start="0" end="5" type="uint" default="2"/>
- <field name="Address" start="66" end="95" type="uint"/>
+ <field name="Address" start="66" end="95" type="address"/>
<field name="Core Mode Enable" start="64" end="64" type="uint"/>
<field name="Data DWord 0" start="96" end="127" type="uint"/>
<field name="Data DWord 1" start="128" end="159" type="uint"/>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
