Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>

On 11/02/17 05:36, Jason Ekstrand wrote:
This fixes a "statement with no effect" compiler warning
---
  src/intel/vulkan/genX_cmd_buffer.c | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/intel/vulkan/genX_cmd_buffer.c 
b/src/intel/vulkan/genX_cmd_buffer.c
index 8db26e9..d07fe78 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/src/intel/vulkan/genX_cmd_buffer.c
@@ -1899,18 +1899,17 @@ genX(cmd_buffer_flush_compute_state)(struct 
anv_cmd_buffer *cmd_buffer)
#if GEN_GEN == 7 -static bool
+static VkResult
  verify_cmd_parser(const struct anv_device *device,
                    int required_version,
                    const char *function)
  {
     if (device->instance->physicalDevice.cmd_parser_version < 
required_version) {
-      vk_errorf(VK_ERROR_FEATURE_NOT_PRESENT,
-                "cmd parser version %d is required for %s",
-                required_version, function);
-      return false;
+      return vk_errorf(VK_ERROR_FEATURE_NOT_PRESENT,
+                       "cmd parser version %d is required for %s",
+                       required_version, function);
     } else {
-      return true;
+      return VK_SUCCESS;
     }
  }
@@ -1981,7 +1980,8 @@ void genX(CmdDispatchIndirect)(
     /* Linux 4.4 added command parser version 5 which allows the GPGPU
      * indirect dispatch registers to be written.
      */
-   if (!verify_cmd_parser(cmd_buffer->device, 5, "vkCmdDispatchIndirect"))
+   if (verify_cmd_parser(cmd_buffer->device, 5,
+                         "vkCmdDispatchIndirect") != VK_SUCCESS)
        return;
  #endif


_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to