On Tue, 2017-02-07 at 10:56 +0100, Marek Olšák wrote: > On Tue, Feb 7, 2017 at 2:57 AM, Kenneth Graunke <kenn...@whitecape.or > g> wrote: > > On Monday, February 6, 2017 8:54:40 PM PST Marek Olšák wrote: > > > On Mon, Feb 6, 2017 at 8:20 PM, Ernst Sjöstrand <ern...@gmail.com > > > > wrote: > > > > FYI glmark2 segfaults with mesa_glthread=true. Expected that > > > > some programs > > > > will segfault? > > > > > > Yes, even segfaults are expected with mesa_glthread=true. > > > > > > Marek > > > > Would it make sense to be crash-free or even regression-free on at > > least Piglit, before merging? (Or are we there already?) > > It's not necessary. glthread is disabled by default. Nobody has > tested > piglit with glthread. That will follow after it's been merged, or > never if it's never merged.
I've been trying to land shader-cache patches that actually do pass piglit for over a year with the same reasoning that it will be disable by default and can only be improved with testing I can't possibly do on my own. Although I have no objections to this being merged I'll be extremely frustrated if this is allowed to be merged known to not even pass piglit while I've wasted countless hours rebasing shader cache over many months. > > Marek > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
