On 11 November 2011 02:56, Kenneth Graunke <kenn...@whitecape.org> wrote:
> match_function_by_name performs two fairly separate tasks: > 1. Hunt down the appropriate ir_function_signature for the callee. > 2. Generate the actual ir_call (assuming we found the callee). > > Both of these are complicated. The first has to handle exact/inexact > matches, lazy importing of built-in prototypes, different scoping rules > for 1.10, 1.20+, and ES. Not to mention printing a user-friendly error > message with pretty-printed "maybe you meant this" candidate signatures. > > The second has to deal with void/non-void functions, pre-call implicit > conversions for "in" parmeters, and post-call "out" call conversions. > > Trying to do both in one function is just too unwieldy. Time to split. > > This patch purely moves the code to generate an ir_call into a separate > function and reindents it. Otherwise, the code is identical. > > Signed-off-by: Kenneth Graunke <kenn...@whitecape.org> > Very sensible. Thanks for making this refactoring a separate commit. Reviewed-by: Paul Berry <stereotype...@gmail.com>
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
