On Thu 02 Feb 2017, Anuj Phogat wrote:
> On Thu, Feb 2, 2017 at 9:03 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote:
> > On Wed, Feb 1, 2017 at 4:07 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote:
> >>
> >> On Wed, Feb 1, 2017 at 2:40 PM, Jason Ekstrand <ja...@jlekstrand.net>
> >> wrote:
> >> > +/**
> >> > + * Returns true if the given format can support single-sample fast
> >> > clears.
> >> > + */
> >> > +bool
> >> > +isl_format_supports_ccs_d(const struct gen_device_info *devinfo,
> >> > + enum isl_format format)
> >> > +{
> >> > + if (!isl_format_supports_rendering(devinfo, format))
> >> > + return false;
> >> > +
> >> Add a check for non-MSRT?
I think it should check or assert the gen version, at least. CCS_D first
appears in gen7. See intel_tiling_supports_non_msrt_mcs().
> > Maybe? There are other things we could potentially check for such as tiling
> > format, num samples, etc. in order to get a full "can this support
> > fast-clears" check. I intended this to be just a format check. Thoughts?
> >
> I'm fine with leaving it as it is with an added comment saying:
> It just checks for format. We need additional checks like tiling format,
> num samples to determine if this can support fast clears.
>
> As you're already here, you might want to add another helper to cover all
> the checks. I'll leave it up to you.
> >>
> >> > + const struct isl_format_layout *fmtl =
> >> > isl_format_get_layout(format);
> >> > +
> >> > + return fmtl->bpb == 32 || fmtl->bpb == 64 || fmtl->bpb == 128;
> >> > +}
> >> > +
> >> > bool
> >> > isl_format_supports_ccs_e(const struct gen_device_info *devinfo,
> >> > enum isl_format format)
> >> > --
> >> > 2.5.0.400.gff86faf
> >> >
> >> > _______________________________________________
> >> > mesa-dev mailing list
> >> > mesa-dev@lists.freedesktop.org
> >> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
> >
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
