On Thursday, January 12, 2017 12:24:41 PM PST Juan A. Suarez Romero wrote:
> This fixes a defect detected by Coverity Scan.
> ---
> src/mesa/drivers/dri/i965/brw_draw_upload.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c
> b/src/mesa/drivers/dri/i965/brw_draw_upload.c
> index b7527f2cd9..abf3859614 100644
> --- a/src/mesa/drivers/dri/i965/brw_draw_upload.c
> +++ b/src/mesa/drivers/dri/i965/brw_draw_upload.c
> @@ -482,6 +482,7 @@ brw_prepare_vertices(struct brw_context *brw)
> brw->vb.nr_enabled = 0;
> while (vs_inputs) {
> GLuint first = ffsll(vs_inputs) - 1;
> + assert (first < 64);
> GLuint index =
> first -
> DIV_ROUND_UP(_mesa_bitcount_64(vs_prog_data->double_inputs_read &
> BITFIELD64_MASK(first)), 2);
> FWIW, I believe the actual bound is (first <= VERT_ATTRIB_MAX + 1). Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
