Hi Wu Zhen, On 6 January 2017 at 17:35, Wu Zhen <wuz...@jidemail.com> wrote: > From: WuZhen <wuz...@jidemail.com> > > adds a new type of winsys handle type that allows passing > a pointer sized handle to winsys > > Change-Id: I3bf1732619206d2bc50f6aca6b27258bb026a212 > Reviewed-by: Mauro Rossi <issor.or...@gmail.com> > Reviewed-by: Chih-Wei Huang <cwhu...@linux.org.tw>
Thanks for splitting things up, yet seems like you've missed a few very important comments. From [1] with extra annotation: " - introduce the DRI extension - _elaborate_ thoroughly why it's needed,how it will be used. - extend the gallium interface - as above, one should _elaborate_ why/how " " - Code from src/egl _cannot_ know about src/gallium and vice-versa. - Gallium can be (is) aware of src/mesa/drivers/dri/common (and include/GL) but _not_ the other way around " " As mentioned above - you _cannot_ change the compile time version (here) while adding the new function ptr at run time (in drisw_init_screen). " And a couple of more comments which came to mind: - prefix non-static functions - function declaration should be in the headers (re: dri2_create_from_texture() and others) Thanks Emil [1] https://patchwork.freedesktop.org/patch/84187/ _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
