On Tue, 2017-01-03 at 08:59 -0800, Jason Ekstrand wrote: > Dave recently added a spirv-specific structure for this sort of > feature enabling. I think it would be better to use that rather than > nir_options. >
Great! This change also avoids me to modify nir_options so I can remove
some patches.
We will send a v3 of the patch series soon.
Thanks,
Sam
> On Dec 16, 2016 8:56 AM, "Juan A. Suarez Romero" <jasua...@igalia.com
> > wrote:
> > From: Samuel Iglesias Gonsálvez <sigles...@igalia.com>
> >
> > Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com>
> > ---
> > src/compiler/spirv/spirv_to_nir.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/compiler/spirv/spirv_to_nir.c
> > b/src/compiler/spirv/spirv_to_nir.c
> > index 11f6248..f4bf3b4 100644
> > --- a/src/compiler/spirv/spirv_to_nir.c
> > +++ b/src/compiler/spirv/spirv_to_nir.c
> > @@ -2525,6 +2525,13 @@ vtn_handle_preamble_instruction(struct
> > vtn_builder *b, SpvOp opcode,
> > case SpvCapabilityInputAttachment:
> > break;
> >
> > + case SpvCapabilityFloat64:
> > + if (!b->nir_options->native_float64) {
> > + vtn_warn("Unsupported SPIR-V capability: %s",
> > + spirv_capability_to_string(cap));
> > + }
> > + break;
> > +
> > case SpvCapabilityGeometryStreams:
> > case SpvCapabilityTessellation:
> > case SpvCapabilityTessellationPointSize:
> > @@ -2532,7 +2539,6 @@ vtn_handle_preamble_instruction(struct
> > vtn_builder *b, SpvOp opcode,
> > case SpvCapabilityVector16:
> > case SpvCapabilityFloat16Buffer:
> > case SpvCapabilityFloat16:
> > - case SpvCapabilityFloat64:
> > case SpvCapabilityInt64:
> > case SpvCapabilityInt64Atomics:
> > case SpvCapabilityAtomicStorage:
> > --
> > 2.9.3
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
signature.asc
Description: This is a digitally signed message part
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
