On 13 December 2016 at 16:09, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Tue, Dec 13, 2016 at 11:08 AM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> On 13 December 2016 at 15:25, Ilia Mirkin <imir...@alum.mit.edu> wrote: >>> On Thu, Dec 8, 2016 at 2:21 PM, Emil Velikov <emil.l.veli...@gmail.com> >>> wrote: >>>> From: Emil Velikov <emil.veli...@collabora.com> >>>> >>>> Since day 1, Vulkan has depended on --with-egl-platforms to select the >>>> platforms build. >>>> >>>> With earlier commits, we've attributed for that internally by renaming >>>> the [internal] conditionals in our build. At the same time having the >>>> --enable-egl and --with-egl-platforms dependency for Vulkan makes no >>>> sense. >>>> >>>> Since where' on the bridge we want to make the conditional generic, thus >>>> others (such as the gallium VL targets) can honour the respective >>>> platforms. >>>> >>>> Cc: mesa-maintain...@lists.freedesktop.org >>>> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> >>>> --- >>>> Should we keep the old configure and error out when anyone provides a >>>> non-default value ? This way they'll have direct feedback how to move >>>> forward. Otherwise they'll likely miss the warning message. >>> >>> I can't tell what problem this is solving. OTOH this is creating the >>> problem that everyone's configure lines will need fixing. >> This need fixing (builder intervention) either way, I'm afraid. Question is >> a) should we expect people to read the release notes, or >> b) get their attention with an error message, providing an example >> in order to do the right thing. > > (c) leave things alone if this isn't fixing anything other than aesthetics. It's not aesthetics... atm if you want just Vulkan you still need --enable-egl --with-egl-platforms=x11,wayland*. Otherwise it won't have any winsys integration... Not sure if it'll build/link properly even :-(
Emil * Admittedly --enable-egl and --with-egl-platforms=x11 is the defaults atm so you're mostly fine by default _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
