On 13 December 2016 at 11:14, Eric Engestrom <eric.engest...@imgtec.com> wrote: > On Thursday, 2016-12-08 19:21:49 +0000, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> >> --- >> Should we keep this here and feed the defines to all sources or apply >> them locally ? >> >> If we go with this approach, need to drop the other existing defines. > > What "other existing defines"? I can't find anything that would use > these either. > I am split whether we want the defines propagated globally, or locally as we do with HAVE_*_PLATFORM in EGL's src/egl/Makefile.am. On the Vulkan side we have to use the VK ones, because of $reasons, thus the hesitation.
> Maybe related: I haven't received anything past patch 11/28, and it > seems neither has mailman's archive [1]. > Is this something you use later in your series? > 10 and 11 [0] are trivial cleanups in st/va that I've noticed while I was going through. Perhaps I should have kept them separate... I don't feel too strong either way. > The patches so far look good to me; everything up to #8 is: > Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > (with the change in #6 that you suggested) > > On a related note, this series will break something I'm working on, but > isn't anywhere near ready yet anyway (-ENOTIME…) ^^ > Pardon for that :-\ Let me know if things are too messy/etc. as you find the time to finish your work. Thanks for having a look ! Emil [0] https://patchwork.freedesktop.org/patch/126454/ _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
