On Mon, Dec 12, 2016 at 1:56 PM, Rafael Antognolli <rafael.antogno...@intel.com> wrote: > On Mon, Dec 12, 2016 at 01:51:01PM -0500, Ilia Mirkin wrote: >> On Mon, Dec 12, 2016 at 1:47 PM, Rafael Antognolli >> <rafael.antogno...@intel.com> wrote: >> >> > It is possible to query for overflow on gen6, so in theory there's no >> >> > reason to not enable it. >> >> >> >> The code (gen6+) doesn't match with the doc changes (gen7+). >> >> >> >> I think the patch subject should also indicate the gen. For example: >> >> >> >> i965/gen6+: Enable arb_transform_feedback_overflow_query >> > >> > Good point, I'll update the patch to make it match gen6+. >> >> I believe your last iteration of piglits requires gen7+ - note that >> gen6 has neither ARB_transform_feedback3 nor ARB_gpu_shader5. > > Hmm... in this case, do you suggest that I change the extension to be > gen7+ only, or would it be better to split the tests?
As I mentioned in a review of the tests, it should be fairly easy to adapt them to make those extensions optional. They're only necessary for the multi-stream stuff, not the overall concept. -ilia _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
