Looks good. I don't remember the MAYBE_UNUSED macro being used that much
in mesa opengl, but it seems it is trendy in vulkan code.
Reviewed-by: Eduardo Lima Mitev <el...@igalia.com>
On 12/10/2016 08:10 PM, Grazvydas Ignotas wrote:
> Signed-off-by: Grazvydas Ignotas <nota...@gmail.com>
> ---
> no commit access, somebody please push
>
> src/intel/vulkan/anv_blorp.c | 3 ++-
> src/intel/vulkan/genX_cmd_buffer.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
> index 159e4a0..b431d6a 100644
> --- a/src/intel/vulkan/anv_blorp.c
> +++ b/src/intel/vulkan/anv_blorp.c
> @@ -909,7 +909,8 @@ anv_cmd_buffer_alloc_blorp_binding_table(struct
> anv_cmd_buffer *cmd_buffer,
> state_offset);
> if (bt_state.map == NULL) {
> /* We ran out of space. Grab a new binding table block. */
> - VkResult result = anv_cmd_buffer_new_binding_table_block(cmd_buffer);
> + MAYBE_UNUSED VkResult result =
> + anv_cmd_buffer_new_binding_table_block(cmd_buffer);
> assert(result == VK_SUCCESS);
>
> /* Re-emit state base addresses so we get the new surface state base
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buffer.c
> index f761d9a..6131cfb 100644
> --- a/src/intel/vulkan/genX_cmd_buffer.c
> +++ b/src/intel/vulkan/genX_cmd_buffer.c
> @@ -697,7 +697,7 @@ genX(cmd_buffer_config_l3)(struct anv_cmd_buffer
> *cmd_buffer,
> assert(!urb_low_bw || cfg->n[GEN_L3P_URB] == cfg->n[GEN_L3P_SLM]);
>
> /* Minimum number of ways that can be allocated to the URB. */
> - const unsigned n0_urb = (devinfo->is_baytrail ? 32 : 0);
> + MAYBE_UNUSED const unsigned n0_urb = devinfo->is_baytrail ? 32 : 0;
> assert(cfg->n[GEN_L3P_URB] >= n0_urb);
>
> uint32_t l3sqcr1, l3cr2, l3cr3;
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
