On 8 December 2016 at 02:03, Tobias Droste <tdro...@gmx.de> wrote:
> This is actually not needed because the version is checked later.
>
> Line 2609:
> if test "x$enable_gallium_llvm" == "xyes"; then
> llvm_require_version $LLVM_REQUIRED_GALLIUM "gallium"
> llvm_add_default_components "gallium"
>
> HAVE_GALLIUM_LLVM=xyes
> DEFINES="${DEFINES} -DHAVE_GALLIUM_LLVM"
> fi
>
> Signed-off-by: Tobias Droste <tdro...@gmx.de>
Reviewed-by: Emil Velikov <emil.veli...@collabora.com>
As i was skimming through last night, a couple of related issues come to light:
- original code (before your work) was buggy and was silently
dropping LLVM even if one explicitly passed --enable-gallium-llvm
Now the default heuristic dominates and "forces" people to have LLVM
or use --disable-gallium-llvm.
Can we use FOUND_LLVM alongside the "is x86 platform" to determine if
we should enable gallium-llvm ?
- we do not change the "auto" to "no" in the !x86 case.
Thanks
Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
