On 5 December 2016 at 22:50, Jeremy Huddleston Sequoia <jerem...@apple.com> wrote: > >> On Dec 5, 2016, at 11:52 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> >> From: Emil Velikov <emil.veli...@collabora.com> >> >> No point in having an identical code in two places. >> >> Not to mention that the Apple one incorrectly uses GLXDrawable as pbuf >> type. This change is both API and ABI safe since the header uses the >> correct GLXPbufferSGIX and both types are a typedef of the same >> primitive XID. >> >> Cc: Jeremy Huddleston Sequoia <jerem...@apple.com> >> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > > Reviewed-by: Jeremy Sequoia <jerem...@apple.com> > (not tested yet, though) > Thanks.
>> --- >> Jeremy, humble poke to send any/all Macports patches to the list ;-) > > What patches are you referring to? AFAIK, all the patches we have in > MacPorts are hacks that have been rejected by mesa or are things I don't > think should be in mesa due to lack of polish/hack status. See: > https://github.com/macports/macports-ports/tree/master/x11/mesa/files > Almost, but not quite ;-) - 0001-mesa-Deal-with-size-differences-between-GLuint-and-G.patch Should not longer be needed with the BUILDING_MESA workaround. - 0002-applegl-Provide-requirements-of-_SET_DrawBuffers.patch Some serious work needed. - 0003-glext.h-Add-missing-include-of-stddef.h-for-ptrdiff_.patch Should not be needed since the header is included further up in the file. Alternatively poke Khronos and upstream it. - no-missing-prototypes-error.patch No traces of it on the list and no commit message describing why it's needed :'-( - patch-include-GL-mesa_glinterop_h.diff No longer needed - fixed upstream - static-strndup.patch We have WIN32(?) strndup in src/util/strndup.[ch]. Static inline into include/posix_string.h alongside strnlen. Or better yet add a patch for the build toolchain, thus one doesn't need to fix these in every project ;-) Thanks Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
