On Wed, Nov 30, 2016 at 1:11 PM, Matt Turner <[email protected]> wrote: > On 11/28, Ian Romanick wrote: >> >> From: Ian Romanick <[email protected]> >> >> I believe that I have addressed all of the review feedback from the >> previous iteration. Many of the patches have been reviewed, and they >> should be ready to go. >> >> Patches marked with "vN" in the subject have changed in a non-trivial >> way since last being sent to he list. >> >> Several patches that have not changed need review: >> >> Patches 23 through 33 add lowering passes for 64-bit operations. > > > I sent a few comments, and I cannot claim to have verified the division > routine, but the rest are > > Reviewed-by: Matt Turner <[email protected]>
Having thought more about this, I think doing this in GLSL IR is not the way we should be going. Presumably we're going to want to support int64 in SPIR-V, and that necessitates lowering these operations in NIR. I don't think it's a good idea to do this outside of NIR. Thoughts? _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
