On Fri, Oct 28, 2011 at 1:49 PM, Eric Anholt <e...@anholt.net> wrote: > Some of the return values were u32, some were 24 bits, and z16 > returned 16 bits. The caller would have to do all the work of > interpreting the format all over again. However, there are no callers > of this function at this point. > --- > src/mesa/main/format_unpack.c | 35 ++++++++++------------------------- > 1 files changed, 10 insertions(+), 25 deletions(-) > > diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c > index 2051f68..adec7d7 100644 > --- a/src/mesa/main/format_unpack.c > +++ b/src/mesa/main/format_unpack.c > @@ -1415,37 +1415,26 @@ _mesa_unpack_float_z_row(gl_format format, GLuint n, > typedef void (*unpack_uint_z_func)(const void *src, GLuint *dst); > > static void > -unpack_uint_z_Z24_S8(const void *src, GLuint *dst) > +unpack_uint_z_Z24_X8(const void *src, GLuint *dst) > { > /* only return Z, not stencil data */ > const GLuint s = *((const GLuint *) src); > - *dst = (s >> 8); > + *dst = (s & 0xffffff00) | (s >> 24);;
double semicolon. Looks good otherwise. -Brian -Brian _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev