On Mon, Nov 28, 2016 at 4:38 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi all, > > On 24 November 2016 at 10:22, Christian König <deathsim...@vodafone.de> wrote: >> Hi, >> >> patch is Reviewed-by: Christian König <christian.koe...@amd.com>. >> > Shouldn't we also change the h264.pic_order_cnt_[lm]sb also to signed ? > > How about field_order_cnt and field_order_cnt_list ? > We seems to be having an odd mix of signed and unsigned for the latter two.
I had a similar question re using vl_rbsp_u, which returns unsigned. However I think the situation here is that these are unsigned values, but math performed on them can generate negative numbers. I haven't looked super-carefully though. > > Thanks > Emil > P.S. Chandu-babu, please send future patches inline [1]. > [1] http://mesa3d.org/devinfo.html#submitting > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
