On Fri, 28 Oct 2011 10:42:32 -0700, "Ian Romanick" <i...@freedesktop.org> wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > Signed-off-by: Ian Romanick <ian.d.roman...@intel.com> > --- > src/glsl/ir_uniform.h | 128 > +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 128 insertions(+), 0 deletions(-) > create mode 100644 src/glsl/ir_uniform.h > > diff --git a/src/glsl/ir_uniform.h b/src/glsl/ir_uniform.h > new file mode 100644 > index 0000000..ba442f8 > --- /dev/null > +++ b/src/glsl/ir_uniform.h
> + /** > + * Set each time the value of the uniform is change. > + * > + * Drivers that do not used the \c ::driver_storage interface should clear > + * this bit when the value of the uniform is updated on the hardware. > + */ > + unsigned dirty:1; Having reached near the end of the patch series, I don't see any user of the dirty bit, nor any reasonable way for someone to actually use the dirty bit. Are you imagining some implementation where somebody's DMAing in the dirty uniform components into an existing hardware uniform buffer? Wouldn't that be a property of driver storage, not this structure?
pgpKENb3mhIm3.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
