Hi Chris, On 22 October 2016 at 11:00, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Xorg may implement fine grained per-drawable serialisation. If the > client is reading from shared pixmap sources, flushing rendering to the > current drawable is not enough (even if the current code did that, it > does not). Instead, following a glXWaitX() ensure that all X rendering to > shared buffers associated with the glXContext is flushed by doing a > DRI2GetBuffers() roundtrip prior to GL rendering. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=52930 > References: https://bugs.freedesktop.org/show_bug.cgi?id=90264 > References: https://bugs.freedesktop.org/show_bug.cgi?id=97914 > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > --- > include/GL/internal/dri_interface.h | 12 ++++++++- > src/glx/dri2_glx.c | 16 ++++++++++-- > src/mesa/drivers/dri/common/dri_util.c | 6 +++++ > src/mesa/drivers/dri/common/dri_util.h | 4 +++ > src/mesa/drivers/dri/i965/brw_context.c | 38 > ++++++++--------------------- > src/mesa/drivers/dri/i965/brw_context.h | 23 +++++++++++++++-- > src/mesa/drivers/dri/i965/intel_screen.c | 5 ++-- > src/mesa/drivers/dri/i965/intel_tex_image.c | 5 ++-- Please split this up a bit - interface + loader, common helpers and i965, or similar.
This way people porting/updating their drivers will have a clear cut on what, where and why. i915 seems identical to the i965 in this regard, can I interest you updating it ? Thanks Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
