On 10/21/2011 11:49 AM, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > Setting this flag prevents declarations of uniforms from being removed > from the IR. Since the IR is directly used by several API functions > that query uniforms in shaders, uniform declarations cannot be removed > after the locations have been set. However, it should still be safe > to reorder the declarations (this is not tested). > > Signed-off-by: Ian Romanick <ian.d.roman...@intel.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41980 > Cc: Brian Paul <bri...@vmware.com> > Cc: Bryan Cain <bryanca...@gmail.com> > Cc: Vinson Lee <v...@vmware.com> > Cc: José Fonseca <jfons...@vmware.com> > Cc: Kenneth Graunke <kenn...@whitecape.org>
I had wondered why we couldn't just check var->mode == ir_var_uniform && var->location == -1, but Ian mentioned that (at least after his upcoming patches) it wasn't set yet. So...I think this plan seems reasonable. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
