On Wed, 19 Oct 2011 13:24:33 -0700, Paul Berry <stereotype...@gmail.com> wrote: Non-text part: multipart/alternative > On 19 October 2011 12:58, Brian Paul <bri...@vmware.com> wrote: > > > On 10/19/2011 01:53 PM, Paul Berry wrote: > > > >> On 18 October 2011 18:07, Brian Paul <brian.e.p...@gmail.com > >> <mailto:brian.e.p...@gmail.com**>> wrote: > >> > >> From: Brian Paul <bri...@vmware.com <mailto:bri...@vmware.com>> > >> > >> > >> --- > >> .../drivers/dri/i965/brw_vec4_**reg_allocate.cpp | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/src/mesa/drivers/dri/i965/**brw_vec4_reg_allocate.cpp > >> b/src/mesa/drivers/dri/i965/**brw_vec4_reg_allocate.cpp > >> index 1ace91f..6de7682 100644 > >> --- a/src/mesa/drivers/dri/i965/**brw_vec4_reg_allocate.cpp > >> +++ b/src/mesa/drivers/dri/i965/**brw_vec4_reg_allocate.cpp > >> @@ -217,7 +217,7 @@ vec4_visitor::reg_allocate() > >> int reg = ra_get_node_reg(g, i); > >> > >> hw_reg_mapping[i] = first_assigned_grf + > >> brw->vs.ra_reg_to_grf[reg]; > >> - prog_data->total_grf = MAX2(prog_data->total_grf, > >> + prog_data->total_grf = MAX2((int) prog_data->total_grf, > >> hw_reg_mapping[i] + > >> virtual_grf_sizes[i]); > >> > >> Since we're storing the result into an unsigned value, I'd prefer to > >> fix the warning by converting the second argument of MAX2 to GLuint > >> rather than converting the first argument of MAX2 to int. > >> > > > > I was wondering which way that should go. The types in that expression > > are: > > > > GLuint total_grf; > > int hw_reg_mapping[]; > > > > can hw_reg_mapping[] values be negative? > > > > -Brian > > > > > No, every element of hw_reg_mapping is a register number, and those go from > zero up. It's possible that a better fix would be to make hw_reg_mapping[] > and and virtual_grf_sizes[] unsigned, but that might have more cascading > effects than you want to deal with. Eric, do you have an opinion?
I despise the signed/unsigned comparison warning because it makes dealing with small positive integers pointlessly painful, at such a low rate of catching real bugs. Both of those things should be unsigned-able, though.
pgp38mdfXtPn6.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
