On 10/20/2016 07:12 PM, Emil Velikov wrote:
On 20 October 2016 at 10:02, Tapani Pälli <tapani.pa...@intel.com> wrote:
While these max values were previously fixed for pbuffer creation, this
change makes also eglGetConfigAttrib() return correct values.

Fixes following dEQP tests:

    dEQP-EGL.functional.create_surface.pbuffer.rgb888_no_depth_no_stencil
    dEQP-EGL.functional.create_surface.pbuffer.rgb888_depth_stencil
    dEQP-EGL.functional.create_surface.pbuffer.rgba8888_no_depth_no_stencil
    dEQP-EGL.functional.create_surface.pbuffer.rgba8888_depth_stencil

Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98326
---
  src/egl/drivers/dri2/egl_dri2.c | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index 4ed8c12..d9e2ad7 100644
--- a/src/egl/drivers/dri2/egl_dri2.c
+++ b/src/egl/drivers/dri2/egl_dri2.c
@@ -241,6 +241,15 @@ dri2_add_config(_EGLDisplay *disp, const __DRIconfig 
*dri_config, int id,
              return NULL;
           break;

+      case __DRI_ATTRIB_MAX_PBUFFER_WIDTH:
+         _eglSetConfigKey(&base, EGL_MAX_PBUFFER_WIDTH,
+                          _EGL_MAX_PBUFFER_WIDTH);
+         break;
+      case __DRI_ATTRIB_MAX_PBUFFER_HEIGHT:
+         _eglSetConfigKey(&base, EGL_MAX_PBUFFER_HEIGHT,
+                          _EGL_MAX_PBUFFER_HEIGHT);
+         break;
+
With this in mind guess we can drop/revert the Android workaround
(commit b1d636aa007c0c354a217024b4befe15cfb5149f) ?
Yes, that should be possible now. I'll send patch for revert in a min.

Cc: "12.0 13.0" <mesa-sta...@lists.freedesktop.org>
Reviewed-by: Emil Velikov <emil.veli...@collabora.com>

Thanks
Emil


_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to