Thanks for doing this. The commit prefix should be "st/mesa:". Other
comments below.
On Tue, Oct 18, 2016 at 8:12 AM, Timothy Arceri
<timothy.arc...@collabora.com> wrote:
> A following patch is going to merge the gl_fragment_program struct into
> a common gl_program and we want to avoid all stages having this array.
> ---
> src/gallium/include/pipe/p_shader_tokens.h | 1 +
> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 33 +++++++++++++++++++++++-
> src/mesa/state_tracker/st_program.c | 40
> ++++++++----------------------
> 3 files changed, 43 insertions(+), 31 deletions(-)
>
> diff --git a/src/gallium/include/pipe/p_shader_tokens.h
> b/src/gallium/include/pipe/p_shader_tokens.h
> index 4a259db..4632468 100644
> --- a/src/gallium/include/pipe/p_shader_tokens.h
> +++ b/src/gallium/include/pipe/p_shader_tokens.h
> @@ -97,6 +97,7 @@ enum tgsi_file_type {
> #define TGSI_WRITEMASK_XYZW 0x0F
>
> enum tgsi_interpolate_mode {
> + TGSI_INTERPOLATE_NONE,
> TGSI_INTERPOLATE_CONSTANT,
> TGSI_INTERPOLATE_LINEAR,
> TGSI_INTERPOLATE_PERSPECTIVE,
Please drop this change. This is the Gallium interface that is
independent from OpenGL. If you want to use a temporary placeholder,
you can use TGSI_INTERPOLATE_COUNT or -1 or ~0. For future patches,
Gallium interface changes should be in separate commits, but I don't
think any such changes will be needed.
Marek
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
