Am Mittwoch, 12. Oktober 2016, 20:21:29 CEST schrieb Emil Velikov: > >> > >> If things error out here, that means that one should finish the other > >> refactoring before using these helpers ? > >> If that's getting too hairy, just add keep the function a simple > >> wrapper around LLVM_COMPONENTS (no LLVM_CONFIG or AC_MSG_ERROR) and > >> add those when it's safe. > > > > Right now this is just a wrapper around LLVM_COMPONENTS. > > Atm, is more than just a dummy wrapper around LLVM_COMPONENTS. > > > If a component does not exist it will later not generate any LLVM_LIBS > > that's why it also doesn't need to be in LLVM_COMPONENTS. > > If it actually is missing, you will only notice during linking / building > > (depending on wether headers are missing or not). > > Looking at the current code - you only _need_ the --components | grep > foo check for the inteljitevents case. > Where/how do you see an issue happening ?
No issue. I can add that function later in the series. Just wanted to say that the function without the error message is practiaclly just a wrapper as the end result is the same. The grep does no harm! But I reorder this a little bit so it is really just a wrapper in the first patches > > -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
