On Wed, Sep 21, 2016 at 10:31 PM, Kenneth Graunke <kenn...@whitecape.org>
wrote:
> commit e07457d0aec96970a39a2dd1cb4e46da6107eb77 removed the last use
> of ctx->Transform on Gen6. It looks like Gen7 never needed this, but
>
Not so much... The mentioned commit actually contains a very nice comment
specifying why NEW_TRANSFORM is needed. On gen6, some elements of
prog_data->param may refer to user clip planes so we need to re-upload push
constants whenever we get NEW_TRANSFORM.
Not sure what the implications are for IVB.
> I copied it over when I originally ported the driver to Ivybridge.
>
> Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>
> ---
> src/mesa/drivers/dri/i965/gen6_vs_state.c | 3 +--
> src/mesa/drivers/dri/i965/gen7_vs_state.c | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/gen6_vs_state.c
> b/src/mesa/drivers/dri/i965/gen6_vs_state.c
> index 5446ef9..849fff9 100644
> --- a/src/mesa/drivers/dri/i965/gen6_vs_state.c
> +++ b/src/mesa/drivers/dri/i965/gen6_vs_state.c
> @@ -60,8 +60,7 @@ gen6_upload_vs_push_constants(struct brw_context *brw)
>
> const struct brw_tracked_state gen6_vs_push_constants = {
> .dirty = {
> - .mesa = _NEW_PROGRAM_CONSTANTS |
> - _NEW_TRANSFORM,
> + .mesa = _NEW_PROGRAM_CONSTANTS,
> .brw = BRW_NEW_BATCH |
> BRW_NEW_BLORP |
> BRW_NEW_PUSH_CONSTANT_ALLOCATION |
> diff --git a/src/mesa/drivers/dri/i965/gen7_vs_state.c
> b/src/mesa/drivers/dri/i965/gen7_vs_state.c
> index 2715b37..7daa018 100644
> --- a/src/mesa/drivers/dri/i965/gen7_vs_state.c
> +++ b/src/mesa/drivers/dri/i965/gen7_vs_state.c
> @@ -74,7 +74,7 @@ upload_vs_state(struct brw_context *brw)
>
> const struct brw_tracked_state gen7_vs_state = {
> .dirty = {
> - .mesa = _NEW_TRANSFORM,
> + .mesa = 0,
> .brw = BRW_NEW_BATCH |
> BRW_NEW_BLORP |
> BRW_NEW_CONTEXT |
> --
> 2.10.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
