On 22 August 2016 at 08:48, Stencel, Joanna <joanna.sten...@intel.com> wrote: > Segfault occurs when destroying EGL surface attached to already destroyed > Wayland window. The fix is to set to NULL the pointer of surface's > native window when wl_egl_destroy_window() is called. > Are you sure one is not supposed to call eglDestroySurface() first and then wl_egl_window_destroy() ? As-is the patch "fixes" a crash (by creating a leak) caused by user misuse. Should we a) leave the crash to teach people about bugs in their code, b) plug the crash yet cause a leak, or c) plus the crash w/o causing a leak.
I'm leaning towards a) or c) since b) only papers over things. -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
