On Mon, Aug 1, 2016 at 2:46 PM, Eric Engestrom <eric.engest...@imgtec.com> wrote: > On Sun, Jul 31, 2016 at 05:49:02PM +0200, Jan Ziak wrote: >> Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > > This is a good change, and with a couple things to fix below, it is: > Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > >> +#include <stdbool.h> > > You should add this include to all the files that need it, instead of > relying on it to be included by some other include.
Done. >> + pdp->hasPresent = true; > > This is a bugfix, unrelated to this refactoring. It should be its own patch. > However, I'm not positive it is correct, so it doesn't get my r-b (yet). I removed the "pdp->hasPresent = true". The change from "int hasPresent" to "bool hasPresent" is still in the patch. grep -R "\<hasPresent\>" shows that the field isn't used anywhere. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
