Re: [Mesa-dev] [PATCH v2 19/27] i965/blorp/clear: Stop stomping the destination format

[Pohjolainen, Topi]

On Tue, Jul 26, 2016 at 03:11:23PM -0700, Jason Ekstrand wrote:
> The blorp_surface_info_init call above should ste the format for us and

                                                set

Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com>

> stomping it later does nothing whatsoever.
> ---
>  src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp 
> b/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
> index daab5db..4d3fe58 100644
> --- a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
> @@ -132,6 +132,7 @@ do_single_blorp_clear(struct brw_context *brw, struct 
> gl_framebuffer *fb,
>     struct brw_blorp_params params;
>     brw_blorp_params_init(&params);
>  
> +   /* Override the surface format according to the context's sRGB rules. */
>     if (!encode_srgb && _mesa_get_format_color_encoding(format) == GL_SRGB)
>        format = _mesa_get_srgb_format_linear(format);
>  
> @@ -220,9 +221,6 @@ do_single_blorp_clear(struct brw_context *brw, struct 
> gl_framebuffer *fb,
>                                 brw_blorp_to_isl_format(brw, format, true),
>                                 true);
>  
> -   /* Override the surface format according to the context's sRGB rules. */
> -   params.dst.view.format = (enum 
> isl_format)brw->render_target_format[format];
> -
>     const char *clear_type;
>     if (is_fast_clear)
>        clear_type = "fast";
> -- 
> 2.5.0.400.gff86faf
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev