On 26 July 2016 at 10:59, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 22 July 2016 at 17:22, Rob Herring <r...@kernel.org> wrote: > >> @@ -100,11 +72,8 @@ vmw_winsys_create( int fd ) >> if (!vmw_winsys_screen_init_svga(vws)) >> goto out_no_svga; >> >> - if (util_hash_table_set(dev_hash, &vws->device, vws) != PIPE_OK) >> - goto out_no_hash_insert; >> - > Any reason why you didn't call pipe_screen_reference_init() here but > you've moved in the driver ? > Grr just hit me - because unlike other drivers svga does not call screen_create in it's winsys. Other drivers did that to reuse the locking for both fd and screen management, but with the separate locks introduced in the series things should be great.
In theory one could 'decouple' the radeon/amdgpu/nouvea... winsys and drivers, just like svga. If they're interested/see value in it. Thanks Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
