On Tuesday, July 19, 2016 12:57:23 PM PDT Jason Ekstrand wrote: > On Mon, Jul 18, 2016 at 10:00 PM, Chris Forbes <chr...@ijw.co.nz> wrote: > > > Seems a little unfortunate to add a random bool to this interface which is > > otherwise fairly descriptive, but OK. > > > > I agree that this is a bit unfortunate. I was going to suggest adding a > flags parameter and a bitfield union but a flags parameter for a single > bool is also kind-of stupid. I vote we keep it as-is and make it a flags > parameter once we have 2 bools. > > --Jason
I agree, this sucks. I've dropped this patch locally in favor of adding a nir_shader_compiler_options::use_interpolated_input_intrinsics flag (which I just folded into patch 3 as it's a tiny amount of code). That was really easy to hook up and is a lot cleaner.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
