Thanks for the suggestion Emil. I modified each un-submitted patch based on the article you provided. Please see the newly submitted patch set.
Regards, Boyuan -----Original Message----- From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: July-14-16 1:07 PM To: Zhang, Boyuan Cc: Christian König; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 02/11] vl: add entry point On 14 July 2016 at 16:06, Zhang, Boyuan <boyuan.zh...@amd.com> wrote: > For example, in patch 5/11 when " VaCreateContext", we used to CALLOC_STRUCT > for "pps" and "sps" whenever we see video format is H.264. This is fine for > decode ONLY case. Now, since we added H.264 encoding, "pps" and "sps" > shouldn't be allocated. So we need to use the entry_point to determine this > is H.264 decode or H.264 encode. We can use config to determine the > entrypoint since config_id is passed to us for VaCreateContext call. However, > for VaDestoyContext call, only context_id is passed to us. So we need to know > the entrypoint in order to not free the pps/sps for encoding case. > This is a perfect example (one might call it too verbose, but that shouldn't be an issue) of a good information to add in the commit message :-) If a question is coming from a person familiar with the code this is a dead giveaway that the commit message is subpar. I would kindly ask that you check through the readings suggested earlier [1] [2]. It seems like you did not have the time/chance. Thanks Emil [1] http://who-t.blogspot.co.uk/2009/12/on-commit-messages.html [2] http://chris.beams.io/posts/git-commit/ _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
