On Fri, 23 Sep 2011 03:04:21 +0200, Henri Verbeet <hverb...@gmail.com> wrote: Non-text part: multipart/mixed > On 23 September 2011 01:48, Eric Anholt <e...@anholt.net> wrote: > > In the case of n == 1 with more than one bit set, doesn't this stomp the > > _ColorDrawBufferIndexes[] we just calculated between n and > > _NumColorDrawBuffers - 1? Looks like splitting that loop into two would > > work well. > > > You're right, how about something like the attached patch? Strictly > speaking the start index for the first loop should be MAX2(n, > fb->_NumColorDrawBuffers), though I'm not sure that's worth it.
Looks good to me. Reviewed-by: Eric Anholt <e...@anholt.net>
pgpqitXgubLF6.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
