On 1 July 2016 at 16:03, Chuck Atkins <chuck.atk...@kitware.com> wrote: >> This part should have been a separate patch. Please try to keep things >> separate for the future. > > > Indeed, I should have this as two separate commits, one to encapsulate the > flag test and another to add additional options to test for. I'll keep them > more segmented in the future. > > >> >> Esp with the IFS override this looks rather nasty imho. > > > I hate messing with IFS as it tends to get ugly real fast, I just couldn't > think of a better way at the time. After sitting with it for a bit longer > now, I've updated the swr_require_cxx_feature_flags function now to not use > IFS. Would you rather I push it as a new patch or just leave it alone for > now? This patch has landed afaict, so if you want to rework it just do so on top of it.
But at the end of the day It's up-to you and/or Tim really. Thanks Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
