On 20 September 2011 17:09, Eric Anholt <e...@anholt.net> wrote:
> On Tue, 20 Sep 2011 15:42:30 -0700, Paul Berry <stereotype...@gmail.com>
> wrote:
> > This patch series enables support for gl_ClipDistance in the Intel
> > i965 driver. The first three patches are in mesa core (and hence
> > potentially affect all drivers); the rest are i965-specific.
> >
> > For those of you who aren't concerned with the i965 driver, you will
> > probably be most interested in looking at patch 2 in the series, which
> > modifies the all-important gl_vert_result and gl_frag_attrib enums. I
> > believe that the changes I've made don't violate any drivers'
> > assumptions about the layout of these enums, but it would be good to
> > get some confirmation about this from people more familiar with
> > non-i965 code.
> >
> > This patch series depends on the patches "glsl hierarchical visitor:
> > Do not overwrite base_ir for parameter lists." and "glsl: Implement a
> > lowering pass for gl_ClipDistance.", which haven't landed yet since
> > the latter is still under discussion. If you want to see the patches
> > in their proper context, you can fetch branch clip-distance from
> > git://github.com/stereotype441/mesa.git.
> >
> > Note that to try out the new functionality you'll need to have i965
> > GEN6 hardware ("Sandy Bridge"), and you'll need to set the environment
> > variable INTEL_GLSL_VERSION=130 to enable the (still experimental)
> > GLSL-1.30 functionality.
>
> The series is:
>
> Reviewed-by: Eric Anholt <e...@anholt.net>
>
Thanks for the review, Eric. Do you have any opinion on the discussion on
"glsl: Implement a lowering pass for gl_ClipDistance."? That discussion
needs to be resolved before I can push this patch series, and the discussion
has some questions directed towards you.
Thanks--
Paul
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
