On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > The spec has been updated adding new PCI IDs. > > Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com> > --- > intel/intel_chipset.h | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h > index e2554c3..0c3ca82 100644 > --- a/intel/intel_chipset.h > +++ b/intel/intel_chipset.h > @@ -194,7 +194,9 @@ > #define PCI_CHIP_KABYLAKE_ULT_GT2 0x5916 > #define PCI_CHIP_KABYLAKE_ULT_GT1_5 0x5913 > #define PCI_CHIP_KABYLAKE_ULT_GT1 0x5906 > -#define PCI_CHIP_KABYLAKE_ULT_GT3 0x5926 > +#define PCI_CHIP_KABYLAKE_ULT_GT3_0 0x5923 > +#define PCI_CHIP_KABYLAKE_ULT_GT3_1 0x5926 > +#define PCI_CHIP_KABYLAKE_ULT_GT3_2 0x5927 > #define PCI_CHIP_KABYLAKE_ULT_GT2F 0x5921 > #define PCI_CHIP_KABYLAKE_ULX_GT1_5 0x5915 > #define PCI_CHIP_KABYLAKE_ULX_GT1 0x590E > @@ -206,7 +208,8 @@ > #define PCI_CHIP_KABYLAKE_HALO_GT2 0x591B > #define PCI_CHIP_KABYLAKE_HALO_GT4 0x593B > #define PCI_CHIP_KABYLAKE_HALO_GT3 0x592B > -#define PCI_CHIP_KABYLAKE_HALO_GT1 0x590B > +#define PCI_CHIP_KABYLAKE_H_GT1_0 0x5908 > +#define PCI_CHIP_KABYLAKE_H_GT1_1 0x590B
Does H here mean Halo? Some of defines have the whole word "HALO" and some "H". Shouldn't we keep that uniform? > #define PCI_CHIP_KABYLAKE_SRV_GT2 0x591A > #define PCI_CHIP_KABYLAKE_SRV_GT3 0x592A > #define PCI_CHIP_KABYLAKE_SRV_GT1 0x590A > @@ -414,7 +417,8 @@ > (devid) == PCI_CHIP_KABYLAKE_ULT_GT1 || \ > (devid) == PCI_CHIP_KABYLAKE_ULX_GT1 || \ > (devid) == PCI_CHIP_KABYLAKE_DT_GT1 || \ > - (devid) == PCI_CHIP_KABYLAKE_HALO_GT1 || \ > + (devid) == PCI_CHIP_KABYLAKE_H_GT1_0 || \ > + (devid) == PCI_CHIP_KABYLAKE_H_GT1_1 || \ > (devid) == PCI_CHIP_KABYLAKE_SRV_GT1) > > #define IS_KBL_GT2(devid) ((devid) == PCI_CHIP_KABYLAKE_ULT_GT2 || \ > @@ -425,7 +429,9 @@ > (devid) == PCI_CHIP_KABYLAKE_SRV_GT2 || \ > (devid) == PCI_CHIP_KABYLAKE_WKS_GT2) > > -#define IS_KBL_GT3(devid) ((devid) == PCI_CHIP_KABYLAKE_ULT_GT3 || \ > +#define IS_KBL_GT3(devid) ((devid) == PCI_CHIP_KABYLAKE_ULT_GT3_0 || \ > + (devid) == PCI_CHIP_KABYLAKE_ULT_GT3_1 || \ > + (devid) == PCI_CHIP_KABYLAKE_ULT_GT3_2 || \ > (devid) == PCI_CHIP_KABYLAKE_HALO_GT3 || \ > (devid) == PCI_CHIP_KABYLAKE_SRV_GT3) > I verified the PCI IDs against the Spec, looks good to me. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
