https://bugs.freedesktop.org/show_bug.cgi?id=96629
Ilia Mirkin <imir...@alum.mit.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nhaeh...@gmail.com
--- Comment #3 from Ilia Mirkin <imir...@alum.mit.edu> ---
42624ea837e8f422f1cd04403af915bd7f218b8d is the first bad commit
commit 42624ea837e8f422f1cd04403af915bd7f218b8d
Author: Nicolai Hähnle <nicolai.haeh...@amd.com>
Date: Mon Jun 6 23:15:10 2016 +0200
st/mesa: use base level size as "guess" when available
When an applications specifies mip levels _before_ setting a mipmap texture
filter, we will initially guess a single texture level. When the second
level
image is created, we try to allocate the full texture -- however, we get
the
base level size guess wrong if that size is odd. This leads to yet another
re-allocation of the texture later during st_finalize_texture.
Even worse, this re-allocation breaks a (reasonable) assumption made by
st_generate_mipmaps, because the re-allocation in the finalization call
will
again allocate a single-level pipe texture (based on the non-mipmap texture
filter!). As a result, mipmap generation fails in interesting ways.
All of this can be avoided by just using the fact that we already know the
size of the base level.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95529
Cc: 12.0 <mesa-sta...@lists.freedesktop.org>
Reviewed-by: Brian Paul <bri...@vmware.com>
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug._______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
