On Sat 11 Jun 2016, Jason Ekstrand wrote:
> ---
> src/intel/isl/isl.h | 6 ++++++
> src/intel/isl/isl_surface_state.c | 42
> ++++++++++++++++++++++++++++++++++++---
> 2 files changed, 45 insertions(+), 3 deletions(-)
>
> diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
> index 36038bc..a987482 100644
> --- a/src/intel/isl/isl.h
> +++ b/src/intel/isl/isl.h
> @@ -833,6 +833,12 @@ struct isl_surf_fill_state_info {
> uint32_t mocs;
>
> /**
> + * The auxilary surface or NULL if no auxilary surface is to be used.
> + */
> + const struct isl_surf *aux_surf;
> + uint64_t aux_address;
> +
I agree with this part of isl's auxiliary surface handling.
Specifically, I agree that the auxiliary surface and the primary surface
should not be bound together at creation time; that is, struct isl_surf
should have no aux sub-surface. Instead, the two surfaces should be
late-bound when creating the RENDER_SURFACE_STATE.
And I agree that we need ISL_FORMAT_*_CCS_* enums. However, we disagree
on the details of the new enums. It's late in the day for me, so I don't
want to delve into the nuances of CCS layout right now. I'll resume
reviewing in the morning.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
