On Sat 11 Jun 2016, Jason Ekstrand wrote: > This fixes 688 Vulkan CTS tests on Haswell.
Whoo! Bugfixes! The PRM states that, on HSW, you also need to program SAMPLER_BORDER_COLOR_STATE correctly for integer formats. I suspect that the CTS tests may be passing by luck. See this encouraging comment in brw_sampler_state.c: /* Haswell's integer border color support is completely insane: * SAMPLER_BORDER_COLOR_STATE is 20 DWords. The first four are * for float colors. The next 12 DWords are MBZ and only exist to * pad it out to a 64 byte cacheline boundary. DWords 16-19 then * contain integer colors; these are only used if SURFACE_STATE * has the "Integer Surface Format" bit set. Even then, the * arrangement of the RGBA data devolves into madness. */ Anyway, this patch is Reviewed-by: Chad Versace <chad.vers...@intel.com> and please add a TODO somewhere for SAMPLER_BORDER_COLOR_STATE. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev