Rob Herring <r...@kernel.org> writes: > The expected stride calculation is completely wrong. It should > ultimately be multiplying cpp and width rather than dividing. The width > also needs to be aligned to the tiling width first before converting to > stride bytes. > > The whole stride check here is possibly pointless. Any buffers which > were allocated outside of vc4 may have strides with larger alignment > requirements. > > Signed-off-by: Rob Herring <r...@kernel.org>
Sorry about that mistake. I think I had only tested it in the simulation environment (where it did catch the bad strides from the server's buffers for glx-tfp and some image tests), but it didn't actually give any coverage of cases that should have worked because window system buffers were all client allocated. Reviewed and pushed.
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
