On Fri, Jun 10, 2016 at 12:28:38PM +0200, Stephan Bergmann wrote: > On 06/10/2016 12:09 PM, Eric Engestrom wrote: > > On Thu, Jun 09, 2016 at 05:13:20PM +0200, Stephan Bergmann wrote: > > > > Since you didn't send this patch from your primary email account, > > you might want to add this line here, otherwise the author will be > > "stephan.bergmann.second...@googlemail.com": > > > > From: Stephan Bergmann <sberg...@redhat.com> > > Add that line where exactly?
At the top, above the commit message. Using `git send-email` on the patch you originally sent does it automatically (I just double-checked). > > (Seriously, this starts to get boring to me. I had a rather trivial > drive-by patch. I got asked to provide it as exactly "git send-email" (a > "git format-patch"'ed attachment apparently didn't suit reviewers, for > whatever reasons), Inline patches allow for inline comments, which most reviewers prefer. It also makes the use of git-am much easier, when someone wants to test your patch, or when a maintainer wants to apply and push your patch. > so I dutifully set up "git send-email" (which I never use > otherwise). It didn't work with my primary SMTP server (which I didn't > bother to investigate into further), so I used another one that happened to > work. I don't really care with what attribution that change would be > merged.) I didn't mean to bother. If you don't care what email address gets attached to your name, feel free to ignore this :) Cheers, Eric _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
