Hi Nayan, Since the core area is VL lease use "gallium/vl:" or just "vl:".
On 7 June 2016 at 14:32, Nayan Deshmukh <nayan26deshm...@gmail.com> wrote: > Apply the luma key filter to the YCbCr values during the CSC conversion > in video buffer shader. The initial values of max and min luma are set > to opposite values to disable the filter initially and will be set when > enabling it. > > Add extra parmeters min and max luma for the luma key filter in > vl_compositor_set_csc_matrix in va, xvmc. Setting them > to opposite value 1.f and 0.f respectively won't effect the CSC > conversion > > v2: -Squash 1,2 and 3 into one patch to avoid breaking build of > other components.(Christian) > -use ureg_swizzle.(Christian) > -change name of the variables.(Christian) > I believe that the vl_compositor_set_csc_matrix changes in patch 4/4 should be squashed in as well. Otherwise this patch will break VDPAU. There's a couple of trivial suggestions below, hope you won't find them too pedantic :-) > void > -vl_compositor_set_csc_matrix(struct vl_compositor_state *s, vl_csc_matrix > const *matrix) > +vl_compositor_set_csc_matrix(struct vl_compositor_state *s, vl_csc_matrix > const *matrix, float luma_min, float luma_max) Can you please wrap this and the header prototype. > vl_csc_get_matrix(VL_CSC_COLOR_STANDARD_IDENTITY, NULL, true, > &csc_matrix); > - vl_compositor_set_csc_matrix(s, (const vl_csc_matrix *)&csc_matrix); > + vl_compositor_set_csc_matrix(s, (const vl_csc_matrix *)&csc_matrix, 1.f, > 0.f); > Any chance if you can use add the 0 (1.0f and 0.0f) through the patch. The above format is quite rate in mesa/gallium. Thanks Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev