On Fri, 2016-06-03 at 18:58 +0200, Vedran Miletić wrote:
> On 06/03/2016 06:32 PM, Emil Velikov wrote:
> >
> > Not sure who much the MESA>Mesa change matters, so I'll leave that
> > to others.
> >
> Could break some applications that check for it. I doubt many do, and
> if
> they do I would suggest to make the change before Clover becomes
> popular, in hope this will be the case at some point.
>
> >
> > >
> > > +#ifdef MESA_GIT_SHA1
> > > + " (" MESA_GIT_SHA1 ")"
> > > +#endif
> > ... but here please drop the ifdef guard. Same goes for the other
> > file.
> >
> This is how OpenGL does it. Do you mind if I drop the include guard
> there as well?
>
> >
> > Please give it some time for others to weight in before sending out
> > v4.it's also a nice touch if you include changes between versions when sending patches. it saves others the trouble to diff the diff. Jan > > > Sure. Sorry for multiple revisions initially. > > Regards, > Vedran > -- Jan Vesely <jan.ves...@rutgers.edu>
signature.asc
Description: This is a digitally signed message part
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
