On 05/13/2016 07:57 AM, Alejandro Piñeiro wrote:
> For ES 3.0 NUM_SAMPLE_COUNTS spec points that some formats will be
> always zero. But on ES 3.1 can be different to zero.
>
> The current code is correctly checking exactly against version 3.0,
> but the comment only mentions 3.0 spec. It is clearer mentioning both.
>
> Acked-by: Eduardo Lima <el...@igalia.com>
> Acked-by: Antia Puentes <apuen...@igalia.com>
> ---
> src/mesa/main/formatquery.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c
> index 1f21d17..1dfec5c 100644
> --- a/src/mesa/main/formatquery.c
> +++ b/src/mesa/main/formatquery.c
> @@ -877,6 +877,9 @@ _mesa_GetInternalformativ(GLenum target, GLenum
> internalformat, GLenum pname,
> * "Since multisampling is not supported for signed and unsigned
> * integer internal formats, the value of NUM_SAMPLE_COUNTS will be
> * zero for such formats.
> + *
> + * But that is not true for GL ES 3.1. This is the reason why we are
> + * checking against exactly version 30, instead of use _mesa_is_gles3.
> */
I think it would be better to say:
Since OpenGL ES 3.1 adds support for multisampled integer formats,
we have to check the version for 30 exactly.
> if (pname == GL_NUM_SAMPLE_COUNTS && ctx->API == API_OPENGLES2 &&
> ctx->Version == 30 &&
> _mesa_is_enum_format_integer(internalformat)) {
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
